[WIP] initiall version of PR build jobs #8
Conversation
| ssh root@${{build_server}} \ | ||
| "cd ${{rwd}}/{package_name}; \ | ||
| make update-release ;\ | ||
| make gitversion ;\ |
There was a problem hiding this comment.
@TimothyAsir would it be possible to unify the Makefiles across the repos, so everywhere will be used make gitversion for updating the Release with timestamp and git hash?
Now there are two make targets for the same action - update-release and gitversion, so I have to call there both commands and expect, that one of them fails.
dahorak
force-pushed
the
pr-build-jobs
branch
2 times, most recently
from
fa4f8c9 to
f0734bf
Compare
|
The Jobs are visible on tendrl-PR CentOS CI Jenkins page and are named |
dahorak
force-pushed
the
pr-build-jobs
branch
from
000e01e to
28ac655
Compare
It will create one job for each repository. Each job perform following steps: - prepare *build_server* machine (or use existing one) - clone desired repository and checkout PR branch - update *Release* with git snapshot and PR number - build source package - submit srpm to copr and wait for the result - download built packages and prepare PR repo on artifacts.ci.centos.org
following two make targets are inconsistently used accross the Tendrl repos - update-release - gitversion
- source packages are not required in the PR rpm repo and use quite huge space
to tendrl-build-triggers-pr-builds.yml
- There seems to be some problem with enabling builds globally for whole the Tendrl organization, so adding specifically particular people to the admin list.
- it seems to send the notification to strange list of email addresses, so disabling it
- limit the job execution only for PR updates
- to ensure PR builds have higher version and will not be overwritten by newest schnapshot packages from master branch
dahorak
force-pushed
the
pr-build-jobs
branch
from
f26183e to
c55546b
Compare
| - github-pull-request: | ||
| admin-list: | ||
| - dahorak | ||
| white-list: |
There was a problem hiding this comment.
Is there a way to input this rather than hardcoding?
There was a problem hiding this comment.
@nthomas-redhat it should be possible, to automatically fetch the list of people from the organization specified below in the org-list section, but there seems to be some problem with this and I'm not sure why it doesn't work and where might be the problem with that.
I'll try to check that once more and find some more information about that - that will be definitely the best solution.
There was a problem hiding this comment.
@nthomas-redhat I've found partial solution for this: it works for people with Public membership.
@r0h4n could you please check, if centos-ci user is part of Tendrl organization?
That might solve the problem with people with private membership in Tendrl org.
(I know, you already added it #6 (comment), but it seems like it is not there https://github.com/orgs/Tendrl/people...)
- for not merged PR, it will contain two hashes for both parents of the temporary merge to master commit (one is for commit from master branch, the second is the last commit in the PR) - for merged PR, it will contain only the hash of the merge commit (or last commit from master)
- packages built in mock are not signed
- it is not possible to send emails to this list outside of RH (from ci@centos.org)
2 participants
It will create one job for each repository.
Each job perform following steps:
submit srpm to copr and wait for the result